Ports-Elise #38
Ports-Elise #38
Conversation
|
|
||
| <nav> | ||
| <ul> | ||
| <nav class="nav-bar"> |
There was a problem hiding this comment.
I like the addition of these classes. I think you did a great job of choosing descriptive names.
| @@ -0,0 +1,349 @@ | |||
| /*! normalize.css v8.0.1 | MIT License | github.com/necolas/normalize.css */ | |||
| background-color: lightgoldenrodyellow | ||
| } | ||
|
|
||
| .nav-bar-list { |
There was a problem hiding this comment.
This looks great and follows the wireframe.
|
|
||
| .container { | ||
| max-width: auto; | ||
| display: grid; |
There was a problem hiding this comment.
If you want to make sure your webpage more responsive to changes, you could try removing the grid display from the container. (I played with this, and removing grid display from your container causes some other unintended changes (that should be easily fixable), but be aware of that!)
| } | ||
|
|
||
| a:hover { | ||
| font-weight: bold; |
There was a problem hiding this comment.
I like this! It really drives attention to the link
| } | ||
|
|
||
| #quote { | ||
| margin-left: 10px; |
There was a problem hiding this comment.
I think using rem or em here like you do other places would help making your webpage even more accessible.
2 participants
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions